Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Add in an app usage page (bug 1129065) #1024

Merged
merged 2 commits into from Feb 19, 2015
Merged

Add in an app usage page (bug 1129065) #1024

merged 2 commits into from Feb 19, 2015

Conversation

andymckay
Copy link
Contributor

apologies for the noise, moved over to a pull request from my repo instead of one on the master

@@ -0,0 +1,13 @@
define('views/usage',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'define' is not defined.

@andymckay
Copy link
Contributor Author

r? @diox and @ngokevin

new pull request, 2nd commit has all the feedback @ngokevin provided in the first pull request.

@andymckay
Copy link
Contributor Author

Old pull request, for reference is here: https://github.com/mozilla/fireplace/pull/1022/files#r24706422

<section class="main">
<div class="subheader">
<h1>
{{ _('App Statistics') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which app is this for? Marketplace? Or what's the bug #

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diox diox changed the title Add in an app usage page Add in an app usage page (bug 1129065) Feb 19, 2015
@diox
Copy link
Member

diox commented Feb 19, 2015

Not wild about standalone.styl.css name either but I don't have any alternate suggestion, so r+

andymckay pushed a commit that referenced this pull request Feb 19, 2015
@andymckay andymckay merged commit da394b0 into mozilla:master Feb 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants