This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
device filtering persist site-wide, don't persist between session (bug 1127080) #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
changed the title
ngokevin
force-pushed
the
compatglobal
branch
2 times, most recently
from
f45546d
to
68dabd1
Compare
ngokevin
changed the title
|
@diox r? Also, do we need device_override? |
ngokevin
force-pushed
the
compatglobal
branch
2 times, most recently
from
04a718c
to
2080dac
Compare
|
I think we can remove device_override. It was added for discoplace, which no longer exists. |
| var filterDevice = caps.device_type(); | ||
|
|
||
| z.body.on('change', '#compat-filter', function() { | ||
| // Update stored preferences and reload view to refresh changes. |
There was a problem hiding this comment.
nit : do we want to keep the "stored" wording when we no longer store the pref in localStorage?
|
Uh, weird test failures. |
ngokevin
force-pushed
the
compatglobal
branch
4 times, most recently
from
6077af8
to
01648d5
Compare
|
tests passing |
|
Going to merge so I can add tracking on top of it, lmk if you see anything else. |
ngokevin
added a commit
that referenced
this pull request
Mar 9, 2015
device filtering persist site-wide, don't persist between session (bug 1127080)
|
oops yes sorry for the lack of reply, I thought it was merged already. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was planned for the New Nav Project, but I'm doing this now so I can start UA tracking engagement with the device filter dropdown.