This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
editorial brand landing header changes (bug 1131721) #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should create a different brand-specific mixin. See colors.styl. excerpt shelves.styl.css[data-shelf-landing-carrier="deutsche_telekom"][data-brand-landing] .brand-landing-icon {
background-color: #e20074;
}
[data-shelf-landing-carrier="deutsche_telekom"][data-brand-landing] .feed-curve {
background-color: rgba(226,0,116,0.75);
}
[data-shelf-landing-carrier="deutsche_telekom"][data-brand-landing] .feed-curve:after {
background-color: rgba(226,0,116,0.55);
bottom: -45px;
content: "";
height: 45px;
left: 0;
position: absolute;
width: 100%;
}
[data-shelf-landing-carrier="kddi"] .feed-landing-header {
background-color: rgba(227,82,5,0.55);
}
[data-shelf-landing-carrier="kddi"] .feed-curve {
background-color: #e35205;
}
[data-shelf-landing-carrier="kddi"][data-brand-landing] .brand-landing-icon {
background-color: #e35205;
}
[data-shelf-landing-carrier="kddi"][data-brand-landing] .feed-curve {
background-color: rgba(227,82,5,0.75);
}
[data-shelf-landing-carrier="kddi"][data-brand-landing] .feed-curve:after {
background-color: rgba(227,82,5,0.55);
bottom: -45px;
content: "";
height: 45px;
left: 0;
position: absolute;
width: 100%;
}
[data-shelf-landing-carrier="mtn"] .feed-landing-header {
background-color: rgba(205,103,35,0.55);
}
[data-shelf-landing-carrier="mtn"] .feed-curve {
background-color: #cd6723;
}
[data-shelf-landing-carrier="mtn"][data-brand-landing] .brand-landing-icon {
background-color: #cd6723;
}
[data-shelf-landing-carrier="mtn"][data-brand-landing] .feed-curve {
background-color: rgba(205,103,35,0.75);
}
[data-shelf-landing-carrier="mtn"][data-brand-landing] .feed-curve:after {
background-color: rgba(205,103,35,0.55);
bottom: -45px;
content: "";
height: 45px;
left: 0;
position: absolute;
width: 100%;
} |
|
Updated. |
| @@ -21,27 +21,59 @@ feed_background_color($color) { | |||
| } | |||
| [data-feed-landing-color="amber"] { | |||
| collection_background_colors($color-collection--amber); | |||
|
|
|||
| &[data-brand-landing] { | |||
There was a problem hiding this comment.
Don't need to wrap with data-brand-landing if we prefix the classes, bad for perf
| @@ -21,27 +41,35 @@ feed_background_color($color) { | |||
| } | |||
| [data-feed-landing-color="amber"] { | |||
| collection_background_colors($color-collection--amber); | |||
There was a problem hiding this comment.
we use 🍟 for that :)
|
Can we give it a white outline on the landing page as well? The circle is hard to make out. r+with consideration/comments |
|
I agree with the border on landing also but I'll have to ask the |
spasovski
added a commit
that referenced
this pull request
Mar 12, 2015
editorial brand landing header changes (bug 1131721)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure I like the approach of messing with the mixin but let me know if you have an alternative suggestion.
Also updates the homepage icons: