move buttons (bug 1161854) #1195
Conversation
ngokevin
force-pushed
the
buttonmove
branch
2 times, most recently
from
21d0bc2
to
3e5fb43
Compare
|
@pwalm quick look? @mstriemer r? |
|
Looks good, but I think we're going to move towards keeping everything in the button in phase one though. The separate word outside the button didn't hold up very well in a design critique. An idea of where we might go: |
|
Should I just make the buttons look like that now? |
|
(Yeah, agree on that question.) |
|
Yeah, might as well! Thanks Kevin. /* Button Shape: / |
|
I don't think we want |
|
👍 |
|
Is the button still stacked? |
|
As in stacked under name/dev/rating? Yep. |
| @@ -50,7 +42,7 @@ $btn-install-font-size = 12px; | |||
| } | |||
| } | |||
| &.installed, | |||
| &.purchased, | |||
| purchased, | |||
ngokevin
force-pushed
the
buttonmove
branch
2 times, most recently
from
4a42b80
to
3ccd7dc
Compare
|
updated |
|
This buttons look great, good work guys! |
| data-product="{{ app|json }}"> | ||
| {% macro market_button(app, data_attrs) %} | ||
| {% set app = buttons.transformApp(app) %} | ||
| <span class="button mkt-app-button product install |
There was a problem hiding this comment.
Why the change to <span> from <button>?
There was a problem hiding this comment.
There was a reason...let me find out.
|
r+wc The button becoming a span seems weird but looks good. |
ngokevin
force-pushed
the
buttonmove
branch
4 times, most recently
from
4f96a1a
to
0f74297
Compare
<a>tag)