content filter (bug 1161860)

[ngokevin]

• reuse <mkt-select>
• waffled under settings.meowEnabled

[ngokevin]

@pwalm visual guidance on the custom select? i'm super-conveniently reusing the platform selector code. i know the styles i whipped up here probably won't fly

[pwalm]

Should just be a standard drop down:

[ngokevin]

That causes trouble since "SHOW" in other languages will often not fit. Plus it's not l10n friendly. I can unpad it and border radius it and make the arrow blue.

[pwalm]

Let's put it all in the drop down: "Show all content", "Show websites", "Show apps"

[mstriemer]

Should content_filter.apiArgs get hooked into the router's processors?

[ngokevin]

it's already all in the dropdown :P

[ngokevin]

Not yet, unless the API is ready for that.

[mstriemer]

I don't think it is.

[ngokevin]

Tweaked the select to look more like the mock.

[mstriemer]

What's the advantage of a <mkt-select> over a <select> here?

[ngokevin]

mkt-select is more stylizable. it's very hard to style a native select. and future mocks show even more custom select styles. Like we can't do things like this with a native, but our custom select is perfect for it:

It makes it easier to go from:

to

[mstriemer]

Cool, r+

[ngokevin]

TODO l8r: hook up in api args processor. UA. thanks y'all