Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

App abuse report with a blank comment cannot be sent #1225

Closed
wants to merge 5 commits into from

Conversation

bmanojkumar
Copy link

Displays an error message,if an empty report is sent through app report abuse button

@chuckharmston
Copy link
Contributor

There seems to be a handful of bugs pigeonholed into your master branch, which is making it hard to review each one individually. Could you separate those out and create separate pull requests for them? You'd want to do something like this:

# Create and checkout a new branch.
git checkout -b <branch_name>

# Copy the commit to the new branch.
git cherry-pick <commit_hash>

# Push the new branch to your fork of the repo.
git push origin <branch_name>

Then you should be able to visit this url:

https://github.com/mozilla/fireplace/compare/master...bmanojkumar:<branch_name>

And create a new pull request from there.

@ngokevin
Copy link
Contributor

Let us know when you clean up this PR, thanks!

@ngokevin ngokevin closed this May 27, 2015
@gurumukhi
Copy link
Contributor

@bmanojkumar did you get a chance to work on this ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants