This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Bug 1190107: Text Issue in Footer Extras. #1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ | |||
| <div class="footer-content"> | |||
| <h1 class="footzilla"><a href="https://www.mozilla.org/" target="_blank">mozilla</a></h1> | |||
| <p> | |||
| {{ _('Except where otherwise <a href="{legal_url}" target="_blank">noted</a>, content on this site is licensed under the <a href="{cc_url}" target="_blank">Creative Commons Attribution Share-Alike License v3.0</a> or any later version.', | |||
| {{ _('<span style="color:#717268">Except where otherwise <a href="{legal_url}" target="_blank">noted</a>, content on this site is licensed under the <a href="{cc_url}" target="_blank">Creative Commons Attribution Share-Alike License v3.0</a> or any later version.</span>', | |||
There was a problem hiding this comment.
inline styles are bad since they add a lot of specificity. preferably we add a class on the p and add the color thru a stylesheet, using one of our Stylus color variables.
|
lmk if you can address my comment. thanks! |
|
Thnks for your imp suggestion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.