This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
back button returns to app from screenshots view (bug 972513) #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually makes you hit back twice if you close the lightbox with the |
| @@ -41,6 +41,10 @@ define('lightbox', | |||
| renderPreviews(); | |||
| } | |||
|
|
|||
| // set an anchor so the back button closes the lightbox instead of | |||
There was a problem hiding this comment.
cap + period on the comments
|
r+wc and squash the commits, nice bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=972513
I spent a good amount of time trying to get the screenshots to be a proper view and linkable. I would still prefer that but the composite view (app detail view with screenshots layered on top) and the current lightbox.js implementation (pulling data from the DOM and doing all the work) made this quite difficult. Setting the hash works as expected.