Improve size, positioning, and color of category icons in desktop dropdown (bug 1055701).

[chuckharmston]

r? @ngokevin @spasovski

This messes up the positioning of icons in the categories page, but that will get changed as part of the overhaul of bug 1055313, so I'm going to leave it for now.

[chuckharmston]

Changes to the SVG introduce space between each row of icons roughly equivalent to the spacing between icons.

[ngokevin]

1055313 is about the navbar. I'm not sure category pages will get overhauled. If we know there's a regression on the cat page, shouldn't we fix it?

[ngokevin]

add linebreak

[chuckharmston]

I know from a quick IRC chat that @pwalm will be including feedback about the icons on that page.

[spasovski]

Yea we're breaking this everywhere else so it can be fixed in the dropdown. Maybe breaking is a strong word but this probably shrinks the intended size on the mobile pages and header titles. I'd rather wait on a visual review before merging this even though the logic seems solid.

[chuckharmston]

Yeah, exactly

On Aug 19, 2014, at 1:38 PM, Kevin Ngo notifications@github.com wrote:

Oh do you mean the mobile categories page? Not the categories landing page?

—
Reply to this email directly or view it on GitHub.

[ngokevin]

I'd feel more comfortable if we didn't regress what we have now. Any categories overhaul will take a day or two, and wouldn't want it messed up for those two days.

[chuckharmston]

Ugh, grepping for the SVG didn't hit those first two use cases. This is why sprites suck and we should get image fragments.

[chuckharmston]

And this is why I should never touch Fireplace.

However, I still maintain that this bug get fixed at some point. It's an eyesore, and our sprite should have space between each icon if we're going to use it in several different places like this.

[ngokevin]

Thanks for doing non-clipping the icons though. I pushed out the changes last Friday night with intention on iterating this week.