This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Firefox Accounts migration banner (bug 1052864) #657
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| // styles for the global site header only. | ||
| @import 'lib'; | ||
|
|
||
| // Add the header's height back as padding. This is overriden when not the | ||
|
|
||
| // header is not `position: fixed`. | ||
| body { | ||
| padding-top: $header-height; | ||
|
There was a problem hiding this comment. As long as it doesn't cause regressions, I'm good. And after applying + clicking around, I see nothing wrong. |
||
| } | ||
|
|
||
| // ***************** Wide Mobile (600+ px) | ||
|
|
||
| // usable on any header | ||
|
|
@@ -9,8 +15,8 @@ | |
| border-top: 1px solid $salt-flat-white; | ||
| border-bottom: 1px solid $seavan-salt-white; | ||
| display-flex(); | ||
| height: $header-height; | ||
| max-height: $header-height; | ||
| position: relative; | ||
| width: 100%; | ||
|
|
||
|
|
@@ -25,7 +31,7 @@ | |
| color: $castle-skull-gray; | ||
| font-size: 18px; | ||
| font-weight: 400; | ||
| line-height: $header-height; | ||
| z-index: 10; | ||
| } | ||
| } | ||
|
|
@@ -45,7 +51,7 @@ | |
| display: block; | ||
| } | ||
| > nav { | ||
| height: $header-height; | ||
| display-flex(); | ||
| position: relative; | ||
| text-align: left; | ||
|
|
@@ -56,7 +62,7 @@ | |
| } | ||
| } | ||
| .site { | ||
| height: $header-height; | ||
| margin: 0 5px; | ||
| width: 200px; | ||
|
|
||
|
|
@@ -197,10 +203,10 @@ | |
| .header-button { | ||
| color: $castle-skull-gray; | ||
| display: block; | ||
| height: $header-height; | ||
| line-height: $header-height; | ||
| text-align: center; | ||
| width: $header-height; // $header-height so it's square. | ||
|
|
||
| // header buttons with icons | ||
| &.icon { | ||
|
|
@@ -425,23 +431,15 @@ | |
| flex(1); | ||
|
There was a problem hiding this comment. I'm glad you're removing this, but check with @ngokevin and @spasovski |
||
| } | ||
| } | ||
| main { | ||
| &:before { | ||
| // This makes a sweet gradient below the header | ||
| // (which will appear when scrolling past the category drop-down menu). | ||
| content: ''; | ||
| display: block; | ||
| gradientLinear(unquote('to top, rgba(15,15,15,0) 0%, rgba(15,15,15,.3) 100%')); | ||
| height: 2px; | ||
| top: $header-height; | ||
| position: fixed; | ||
| width: 100%; | ||
| z-index: 18; | ||
|
|
@@ -465,7 +463,7 @@ main { | |
| } | ||
| } | ||
| [data-page-type] main { | ||
| padding: 0 0 $header-height; | ||
|
|
||
| &:before { | ||
| display: none; | ||
|
|
@@ -477,6 +475,10 @@ main { | |
|
|
||
| // This probably shouldn't be media query based. | ||
| @media $wider-desktop { | ||
| body { | ||
| padding-top: 0; | ||
| } | ||
|
|
||
| .header-button.settings { | ||
| right: 0; | ||
| top: 0; | ||
|
|
@@ -514,7 +516,7 @@ main { | |
| > nav { | ||
| height: 60px; | ||
| margin: 0 auto; | ||
| max-width: $max-site-width; | ||
| } | ||
| .site { | ||
| margin: 0; | ||
|
|
@@ -594,13 +596,12 @@ main { | |
| } | ||
|
|
||
| // ***************** Wide Mobile (> 671px) | ||
| @media $at-least-desktop { | ||
| .secondary-header { | ||
| background: none; | ||
| border: 0; | ||
| height: $header-height; | ||
| max-height: $header-height; | ||
| position: relative; | ||
|
|
||
| &:before { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| @import 'lib'; | ||
|
|
||
| .mkt-banner { | ||
| background: $grey-gardens-gray; | ||
| color: $cement-gray; | ||
| display: block; | ||
| overflow: hidden; | ||
| position: relative; | ||
|
|
||
| &:before, | ||
| &:after { | ||
| content: ""; | ||
| display: block; | ||
| height: 1px; | ||
| position: relative; | ||
| top: -1px; | ||
| width: 100%; | ||
| } | ||
|
|
||
| &:after { | ||
| bottom: -1px; | ||
| top: auto; | ||
| } | ||
|
|
||
| .mkt-banner-content { | ||
| $content-height = 60px; | ||
| $content-padding-verticle = 10px; | ||
| background: url("../img/logos/firefox-64.png") no-repeat scroll 0px 50% / 64px 60px transparent; | ||
|
There was a problem hiding this comment. you can't use just make a separate There was a problem hiding this comment. you don't need to include |
||
| // Center the text vertically. Only one line, sorry. | ||
|
|
||
| line-height: $content-height - (2 * $content-padding-verticle); | ||
| margin: 0 auto; | ||
| max-width: $max-site-width; | ||
| min-height: $content-height; | ||
| padding: $content-padding-verticle 40px $content-padding-verticle 70px; | ||
| position: relative; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .close { | ||
| margin-top: -17px; | ||
| top: 50%; | ||
| } | ||
| } | ||
|
|
||
| .mkt-banner.mkt-banner-success { | ||
| background: #64be3c; | ||
| color: #fff; | ||
| font-family: $open-stack; | ||
|
There was a problem hiding this comment. why do you have to set the font family here? |
||
|
|
||
| .mkt-banner-content { | ||
| line-height: 1; | ||
| font-size: 15px; | ||
| font-weight: 300; | ||
| } | ||
|
|
||
| small { | ||
| display: block; | ||
| font-size: 12px; | ||
| padding-top: 10px; | ||
| } | ||
|
|
||
| a { | ||
| color: #fff; | ||
| font-weight: 500; | ||
| text-decoration: underline; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,13 +98,6 @@ body { | |
| position: relative; | ||
| } | ||
|
|
||
| .row { | ||
| clear: both; | ||
| } | ||
|
|
||
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to remove from Zamboni