This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Add recommendation page (bug 1054086) #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't quite done yet... It needs an image for the recommendation page (bug 1072624). But I think it's close enough for ripping apart and telling me what I missed. |
|
You can choose one of the editorial brand icons in our img folder for now. But actually there is a bug to get rid of the images and just center the headers. |
| 'use strict'; | ||
|
|
||
| var gettext = l10n.gettext; | ||
| var console = log('new'); |
There was a problem hiding this comment.
hehe you fixed it up there but not here
|
For swiping: https://github.com/mozilla/fireplace/blob/master/src/media/js/navbar.js#L11 (Rob): Thanks. |
|
TODO finished and screenshots updated. This now will hide the "Recommended" nav item when the waffle switch is disabled or for anonymous users. Re-r? |
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop:
Mobile:
