Smooth CSS transition for FxA popup (bug 1074348) #689
Conversation
| // Hide the regular UI for standalone pages. | ||
| [data-page-type=standalone-loading] { | ||
| > * { | ||
| display: none !important; |
There was a problem hiding this comment.
It's only going to apply for a few seconds and I really don't want to show that stuff. So it seemed !important.
There was a problem hiding this comment.
I don't want to be specific in case the layout changes. So I think that pretty much means it needs to be !important.
There was a problem hiding this comment.
you'd rather do this instead of remove with JS?
There was a problem hiding this comment.
If I did this in JavaScript I'd need to loop through all the children in body and remove the ones that aren't main taking care not to remove any scripts or stylesheets (or something else useful) that may be in there.
I really just want to hide the visual elements so I think this makes the most sense.
|
r+wd¹: I did not test this locally __ |
mstriemer
force-pushed
the
wait-for-stylesheet-popup-1074348
branch
from
b301025
to
ae447e9
Compare
Smooth CSS transition for FxA popup (bug 1074348)
https://bugzilla.mozilla.org/show_bug.cgi?id=1074348
No gifs for this one because they drop the unstyled content flash.
Before: https://www.dropbox.com/s/t1c9fbf5nzw7s9j/reload-before.mov?dl=0
After: https://www.dropbox.com/s/2hvmvqrmbau415c/reload-after.mov?dl=0