This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
move waffle to diff endpoint (bug 1079681) #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
waffle
branch
3 times, most recently
from
9940842
to
ebe198f
Compare
|
I like the idea of moving waffles to its own endpoint, but aren't we re-inventing the offline cache mechanism here ? |
|
I think the offline cache mechanism you're thinking of is the one implemented in builder's |
|
Nvm, I see the caching mechanism you're talking about. Yeah, you're right, requests.get + the cache whitelist should handle it. I thought it was blocking. |
|
Yeah, we might want to double-check that it's working properly, but I think it does exactly the same thing you are doing here, transparently. |
ngokevin
force-pushed
the
waffle
branch
2 times, most recently
from
dcbac8f
to
8086963
Compare
ngokevin
changed the title
|
re-r? |
|
Going to merge so I can remove consumer_info from other projects and get them on the upgrade path for FxA. |
ngokevin
added a commit
that referenced
this pull request
Oct 9, 2014
move waffle to diff endpoint (bug 1079681)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.