This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Include some help text on the FxA email form (bug 1095626) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| <div class="fxa-box"> | |||
| <div id="fox-logo" style="opacity: 1;"></div> | |||
| <div id="stage"> | |||
| <div id="main-content" data-view-state="email"> | |||
There was a problem hiding this comment.
Is this data attr no longer required?
There was a problem hiding this comment.
I am calling showEmailForm explicitly now so it will get set there.
Previously if the server took a while to return the account status you'd briefly see the email form then be redirected to FxA if you were signed in with Persona. With this change you shouldn't see anything.
|
r+wc |
mstriemer
added a commit
that referenced
this pull request
Nov 28, 2014
Include some help text on the FxA email form (bug 1095626)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in mozilla/marketplace-core-modules#9 too.