This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
refresh op shelf detail page (bug 1103300) #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ngokevin
commented
Jan 13, 2015
ngokevin
commented
- re-use collection stuff. pretty straightforward.
- will need to do stuff with op shelf colors since those are hard-coded via CSS. but will handle at the curves stage.
- minus 111 LOC. bam
| @@ -10,14 +11,11 @@ define('views/feed/feed_shelf', ['jquery', 'l10n', 'utils', 'utils_local', 'z'], | |||
|
|
|||
| var slug = args[0]; | |||
| builder.start('feed/feed_shelf.html', { | |||
| landing: true, | |||
| slug: slug | |||
There was a problem hiding this comment.
Can probably have builder.start() be all one-line now.
There was a problem hiding this comment.
could, but most builder.starts look like this so it's easy to spot. plus we always might add more vars
|
You'll want to add the 'app' class to the direct-children li's of |
|
r+wc seems good locally |
|
a |
|
|
ngokevin
added a commit
that referenced
this pull request
Jan 13, 2015
refresh op shelf detail page (bug 1103300)
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.