Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

refresh op shelf & collection background and curves colors (bug 1103301) #912

Merged
merged 1 commit into from Jan 21, 2015
Merged

refresh op shelf & collection background and curves colors (bug 1103301) #912

merged 1 commit into from Jan 21, 2015

Conversation

ngokevin
Copy link
Contributor

  • Our default shelf color is red for carriers that don't specify a color (many of them). @pwalm do you care about that? EDIT: changed to blue
  • add some feed tweaks/fixes

screen shot 2015-01-20 at 3 09 21 pm
screen shot 2015-01-20 at 3 09 32 pm
screen shot 2015-01-20 at 3 10 01 pm
screen shot 2015-01-20 at 3 09 43 pm
screen shot 2015-01-20 at 3 09 52 pm
screen shot 2015-01-20 at 3 10 04 pm

@ngokevin ngokevin force-pushed the feed-shelf-curves branch 3 times, most recently from 4deab7e to 3c6cfb4 Compare January 17, 2015 02:36
@ngokevin ngokevin changed the title refresh op shelf background and curves colors (bug 1103301) refresh op shelf & collection background and curves colors (bug 1103301) Jan 17, 2015
@ngokevin ngokevin force-pushed the feed-shelf-curves branch 2 times, most recently from 23fa3f0 to 75e8ee0 Compare January 17, 2015 02:44
@pwalm
Copy link

pwalm commented Jan 19, 2015

Hmmm... Default red is a bit flashy. Let's go with the lighter blue colour: #0098cf

@pwalm
Copy link

pwalm commented Jan 19, 2015

Oh, and the colour should carry down into the app background on mobile, just like it does on desktop.

@ngokevin
Copy link
Contributor Author

@pwalm updated screenshots. I had to wing some stuff.

@pwalm
Copy link

pwalm commented Jan 20, 2015

Looks good, we just need the dividing line between apps.

@ngokevin
Copy link
Contributor Author

@pwalm For mobile only?

@pwalm
Copy link

pwalm commented Jan 20, 2015

Nope, all of em. 1px, #ffffff:

screen shot 2015-01-20 at 3 19 00 pm

@ngokevin
Copy link
Contributor Author

Added them back, but they need a bit of work:

screen shot 2015-01-20 at 3 36 07 pm

spasovski
spasovski reviewed Jan 21, 2015
View reviewed changes
src/media/css/app-list.styl
&.expanded .app-list-app {
padding-bottom: 40px;
}
li:not(.loadmore):not(:last-child) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much .app-list-app:last-child no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there was a loadmore button, that'd select it right

@spasovski
Copy link
Contributor

Don't think the last child should have a bottom border but that's my white pseudo element which works on non-colored lists. Easy to fix just define the :after with :not(.app-list-colored) but not a biggie in either case since it looks decent even with a bottom border.

@ngokevin
Copy link
Contributor Author

I can get rid of the bottom border I think

@spasovski
Copy link
Contributor

Nicely done r+wc, ignore the few CSS nitpicks if you wish.

@ngokevin
Copy link
Contributor Author

thanks

ngokevin added a commit that referenced this pull request Jan 21, 2015
@ngokevin
Merge pull request #912 from ngokevin/feed-shelf-curves
942a281 
refresh op shelf & collection background and curves colors (bug 1103301)
@ngokevin ngokevin merged commit 942a281 into mozilla:feed Jan 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngokevin @pwalm @spasovski