Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

Commit

Permalink
Merge pull request #526 from lgp171188/1144476-stop-logging-updated-t…
Browse files Browse the repository at this point in the history
…s-errors

[bug 1144476] stop logging update_ts errors
  • Loading branch information
willkg committed Mar 18, 2015
2 parents 1cac166 + 026d9ae commit 9b3e263
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions fjord/heartbeat/api_views.py
Expand Up @@ -17,13 +17,14 @@ def as_view(cls, **initkwargs):
view = super(HeartbeatV2API, cls).as_view(**initkwargs)
return cors_enabled('*', methods=['POST'])(view)

def rest_error(self, post_data, errors):
def rest_error(self, post_data, errors, log_errors=True):
statsd.incr('heartbeat.error')
j_error('heartbeat', 'HeartbeatV2API', 'post', 'packet errors',
metadata={
'post_data': post_data,
'errors': errors
})
if log_errors:
j_error('heartbeat', 'HeartbeatV2API', 'post', 'packet errors',
metadata={
'post_data': post_data,
'errors': errors
})
return rest_framework.response.Response(
status=400,
data={
Expand Down Expand Up @@ -76,7 +77,9 @@ def post(self, request):
return self.rest_error(
post_data,
{'updated_ts': ('updated timestamp is same or older than '
'existing data')})
'existing data')},
log_errors=False
)

# Everything is valid, so we update the Answer and save it.

Expand Down

0 comments on commit 9b3e263

Please sign in to comment.