Merge pull request #642 from willkg/1192812-more-ios

[bug 1192812] Fix platform inferring for firefox for ios
mozilla · Aug 20, 2015 · d6482c9 · d6482c9
2 parents 6ecf455 + 514fd8e
commit d6482c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/fjord/feedback/models.py b/fjord/feedback/models.py
@@ -403,6 +403,9 @@ def infer_platform(cls, product, browser):
                 return browser.platform + ' ' + browser.platform_version
             return browser.platform
 
+        elif product == u'Firefox for iOS':
+            return browser.platform + ' ' + browser.platform_version
+
         return u''
 
 

diff --git a/fjord/feedback/tests/test_views.py b/fjord/feedback/tests/test_views.py
@@ -411,6 +411,7 @@ def test_urls_product_inferred_platform_fxios(self):
         feedback = models.Response.objects.latest(field_name='id')
         assert feedback.locale == 'en-US'
         assert feedback.product == 'Firefox for iOS'
+        assert feedback.platform == 'iPhone OS 8.4'
         assert feedback.browser == 'Firefox for iOS'
         assert feedback.browser_version == '1.0'
         assert feedback.browser_platform == 'iPhone OS'