This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
[bug 936625] Add country to serializer #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the country to the serializer so it gets captured by the API and stored in the db. This adds a test that wouldn't have found this problem, but is a good test to have anyhow since it makes sure all the pieces line up and that we're testing a "maximal" API call.
|
This LGTM. r+ The form is saving the country correctly, right? So the issue is only for the new feedback app... i didnt realize that was live |
|
nvm, the form uses the API, duh |
|
Thanks! Landed in master in 2abca90 [bug 936625] Add country to serializer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the country to the serializer so it gets captured by the API
and stored in the db.
This adds a test that wouldn't have found this problem, but is a good
test to have anyhow since it makes sure all the pieces line up and that
we're testing a "maximal" API call.
Quick r?