Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

[bug 948998] Fix bigram links with no start dates #195

Merged
merged 1 commit into from Dec 12, 2013
Merged

[bug 948998] Fix bigram links with no start dates #195

merged 1 commit into from Dec 12, 2013

Conversation

willkg
Copy link
Member

@willkg willkg commented Dec 12, 2013

This hard codes the start date for bigram links to the dashboard to
2013-01-01 which is a hack to force the dashboard to show all of the
responses with this bigram.

I was going to work through a more serious solution but, as I explain in the comment, there doesn't seem to be a compelling reason to do a more serious solution right now. Ergo, go for the hack now and change it later if need be.

Quick r?

This hard codes the start date for bigram links to the dashboard to
2013-01-01 which is a hack to force the dashboard to show all of the
responses with this bigram.
@willkg
Copy link
Member Author

willkg commented Dec 12, 2013

Easy way to test:

  1. log in
  2. click on "analytics dashboard" tab
  3. click on the occurrences report link
  4. type in a valid product and a valid search for your data--but don't specify date start or date end
  5. click on a bigram link

In the upper left hand section of the dashboard, the start date should be 2013-01-01 and the dashboard graph should look crazy because it's trying to show a year's worth of data in one tiny graph.

@rlr
Copy link
Contributor

rlr commented Dec 12, 2013

the fix WFM. r+

@willkg willkg merged commit c44b5e5 into mozilla:master Dec 12, 2013
@willkg
Copy link
Member Author

willkg commented Dec 12, 2013

Landed in master in c44b5e5 [bug 948998] Fix bigram links with no start dates

@willkg willkg deleted the bigram-link-fix-948998 branch December 12, 2013 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants