This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
[bug 949000] Switch product list to dropdown #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The occurrences report now uses a dropdown list of all available products.
|
To test, go to the occurrences report and notice it's now a dropdown. |
| <input id="id_product" type="text" name="product" value="{{ form.product.value() }}" /> | ||
| <select id="id_product" name="product"> | ||
| {% for prod in products %} | ||
| <option value="{{ prod }}">{{ prod }}</option> |
There was a problem hiding this comment.
This is missing one thing. You should set the selected attribute on the product you just used for the report.
|
^^^ Fixes the selected thing. |
|
WFM R+! |
|
Landed in e951be8 [bug 949000] Switch product list to dropdown |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The occurrences report now uses a dropdown list of all available
products.
r?