Fixes for bug 1112084 and some doc changes #417
Conversation
| @@ -57,6 +57,9 @@ sudo -H -u vagrant virtualenv $VENV | |||
| # Install Fjord requirements | |||
| sudo -H -u vagrant $VENV/bin/python ./peep install -r requirements/requirements.txt | |||
|
|
|||
| # Install Fjord dev requirements | |||
| sudo -H -u vagrant $VENV/bin/pip install -r requirements/dev.txt | |||
There was a problem hiding this comment.
Since dev.txt has hashes in it, you should probably use peep here, instead of pip.
There was a problem hiding this comment.
@willkg said this on #input "we should install it with pip--not peep. that way we get dependencies. we don't really care about making sure what we are installing is exactly what we installed last time for dev libraries.". So I guess, I could remove the hashes and probably the version numbers as well.
There was a problem hiding this comment.
Ok. @willkg trumps me here. I would leave the version numbers. I don't care about the hashes, they could stay or go.
There was a problem hiding this comment.
The hashes and version numbers are there since I copy-pasted the contents from kitsune :)
Create a requirements/dev.txt and specify the dev requirements in it
Since we now have a requirements/dev.txt listing all the dev requirements, we can install those requirements while provisioning the VM. This is a better way to fix bug 1075563.
flake8 is automatically installed while the VM is provisioned
|
This looks good to me. Thank you! |
Fixes for bug 1112084 and some doc changes
All the dev requirements have been specified in requirements/dev.txt and are installed while the VM is provisioned. Docs have been updated for the current pre-commit hook. The users no longer have to install flake8 manually.