[bug 1108755] Add a git commit message linter

[lgp171188]

As mentioned in the comments of bug 1108755 as requirements,
the commit message linter does the following things:

1. Enforces max. 79 characters per line
2. Verifies the summary line has bug numbers in the right format
3. Does a bugzilla lookup for the bug and prints out the 'bug id',
   'summary' and 'assigned to' fields.

[willkg]

Nit: This line is indented 3 spaces and the preceeding line has a \ in it. The fjord code tends to do things like:

if (re.compile(...) and
        re.search(r' ...)):

in this situation.

[willkg]

The nits are very minor and not a big deal.

However, when I run this in the vagrant vm, I get this:

(fjordvagrant)vagrant@vagrant-ubuntu-trusty-64:~/fjord$ bin/lint_commit_msg.py COMMIT_MSG 
Traceback (most recent call last):
  File "bin/lint_commit_msg.py", line 7, in <module>
    from requests.exceptions import (
ImportError: cannot import name ConnectTimeout

I think we need to change the code so it works with requests 1.1 which is what's installed in the vagrant vm.

[willkg]

You should have lint_commit_msg return an int and then have the sys.exit() call here. That way the script doesn't short-circuit and it's easier to test.

[willkg]

This looks great! Thank you!

[willkg]

a36a231 [bug 1108755] Add a git commit message linter