Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

Upgrade south #424

Closed
wants to merge 1 commit into from
Closed

Upgrade south #424

wants to merge 1 commit into from

Conversation

lgp171188
Copy link
Contributor

Things done to upgrade south:
1. Update South to version 1.0.1 in requirements.txt using peep
2. Rename all 'migrations' directories to 'south_migrations'
3. Build a new VM and verify that the migrations apply.
4. Run the unit tests and verify nothing is broken.

South package present in vendor/packages has not been updated

@lgp171188 lgp171188 changed the title Upgrade south and fix a bug in the commit message lint script Upgrade south Dec 19, 2014
@willkg
Copy link
Member

willkg commented Jan 8, 2015

Two things:

  1. The top-level migrations directory is actually for a different migration system called schematic which we never used. I'm putting together a PR now to remove that and some other bits.
  2. South did a 1.0.2 release on 2014-12-23. We should update this PR to use that.

http://south.readthedocs.org/en/latest/releasenotes/1.0.2.html

Also, can you rebase this off of the current master tip? That just makes it a little easier.

@lgp171188
Copy link
Contributor Author

I have updated South to 1.0.2 version and rebased this branch on top of the current master tip.

@lgp171188
Copy link
Contributor Author

Need to rebase again since schematic files are removed from master

@lgp171188
Copy link
Contributor Author

Rebased on top of master, can be reviewed now.

@willkg
Copy link
Member

willkg commented Jan 9, 2015

Looks like you moved the migrations/ directory into a new south_migrations/ directory. e.g.:

fjord/analytics/migrations/0001_initial.py -> fjord/analytics/south_migrations/migrations/0001_initial.py

However, that should be:

fjord/analytics/migrations/0001_initial.py -> fjord/analytics/south_migrations/0001_initial.py

Looks like that's true of all the directories. I think once we fix that, when you do:

./manage.py migrate

it'll stop complaining about missing migrations folders.

Things done:
1. Update South to version 1.0.2 in requirements.txt using peep
2. Rename all 'migrations' directories to 'south_migrations'
3. Build a new VM and verify that the migrations apply.
4. Run the unit tests and verify nothing is broken.

South package present in vendor/packages has not been updated
@lgp171188
Copy link
Contributor Author

Oops! It was done correctly before the rebase. I can say that because I did run the tests and all of them passed when I had given the original pull request. But when I did the rebase, I think I did it in a hurry and didn't properly check the result before commit. I have fixed it now. :)

@willkg willkg mentioned this pull request Jan 9, 2015
@willkg
Copy link
Member

willkg commented Jan 9, 2015

Landed via PR #440 in 4c5072b [bug 900992] Update south to 1.0.2

@willkg willkg closed this Jan 9, 2015
@lgp171188 lgp171188 deleted the upgrade-south branch January 15, 2015 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants