Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

[bug 1127431] Add survey filtering to hbdata view #465

Merged
merged 1 commit into from Jan 30, 2015
Merged

[bug 1127431] Add survey filtering to hbdata view #465

merged 1 commit into from Jan 30, 2015

Conversation

willkg
Copy link
Member

@willkg willkg commented Jan 30, 2015

  • add survey filtering to hb data view with drop down
  • tweak the summarytable style to have less left/right padding

r?

@willkg
[bug 1127431] Add survey filtering to hbdata view
94b5292 
* add survey filtering to hb data view with drop down
* tweak the summarytable style to have less left/right padding
rlr
rlr reviewed Jan 30, 2015
View reviewed changes
fjord/analytics/templates/analytics/analyzer/hb_data.html
<option value="{{ obj.id }}"{% if survey and survey.id == obj.id %} selected{% endif %} >{{ obj.name }}</option>
{% endfor %}
</select>
<input type="hidden" name="sortby" value="{{ sortby }}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page parameter gets tossed. And yeah, that's what I would expect when changing a filter (going back to page 1). 👍

@rlr
Copy link
Contributor

rlr commented Jan 30, 2015

r+!

willkg added a commit that referenced this pull request Jan 30, 2015
@willkg
Merge pull request #465 from willkg/1127431-survey-filter
78769b2 
[bug 1127431] Add survey filtering to hbdata view
@willkg willkg merged commit 78769b2 into mozilla:master Jan 30, 2015
@willkg
Copy link
Member Author

willkg commented Jan 30, 2015

94b5292 [bug 1127431] Add survey filtering to hbdata view

Thank you!

@willkg willkg deleted the 1127431-survey-filter branch January 30, 2015 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@willkg @rlr