Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

[bug 1218381] Fix run_l10n_completion runs #703

Merged
merged 1 commit into from
Nov 5, 2015
Merged

[bug 1218381] Fix run_l10n_completion runs #703

merged 1 commit into from
Nov 5, 2015

Conversation

willkg
Copy link
Member

@willkg willkg commented Nov 4, 2015

It looks like the script is running just fine, but it's putting the
file in the source tree rather than the web tree and that's not
correct. We need to put it in the web tree so that it's available
everywhere.

Pretty sure this should fix it.

r?

It looks like the script is running just fine, but it's putting the
file in the source tree rather than the web tree and that's not
correct. We need to put it in the web tree so that it's available
everywhere.

Pretty sure this should fix it.
@willkg
Copy link
Member Author

willkg commented Nov 4, 2015

@mythmon Does this look right? It's curious since as it stands now, I'm not sure how it ever worked, but it definitely did since I used it to track things. Further, the call on kitsune is totally different:

30 03 * * * root {{ rscripts }} scripts/l10n_completion.py --truncate 30 locale media/uploads/l10n_history.json media/uploads/l10n_summary.json

That puzzles me greatly since I'm pretty sure I wrote both of them.

@mythmon
Copy link
Contributor

mythmon commented Nov 5, 2015

The new version doesn't look worse than the old one, and that path is indeed the right one. I'm confused by the parenthesis in the cronline, but that's probably not important.

bin/run_l10n_completion.sh does a lot of stuff, but one of the things it does looks a lot like Sumo's version of this cron job.

Without looking at git history, I'd imagine that run_l10n_completion.sh got changed, and the cronjob didn't get updated. That would explain how it used to work, but doesn't now.

@mythmon
Copy link
Contributor

mythmon commented Nov 5, 2015

r+

@willkg
Copy link
Member Author

willkg commented Nov 5, 2015

I'm suspecting it's a change on the servers. Maybe at one point source == webapp. Hard to say for sure, though. :(

Thank you for looking at it!

willkg added a commit that referenced this pull request Nov 5, 2015
[bug 1218381] Fix run_l10n_completion runs
@willkg willkg merged commit 0615534 into mozilla:master Nov 5, 2015
@willkg willkg deleted the 1218381-completion branch November 9, 2015 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants