Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize main nav #3631

Closed
gideonthomas opened this issue Sep 9, 2019 · 8 comments
Closed

Localize main nav #3631

gideonthomas opened this issue Sep 9, 2019 · 8 comments
Labels
blocked engineering localization 🌎
Milestone
Icebox

Comments

@gideonthomas
Copy link
Contributor

gideonthomas commented Sep 9, 2019 •
edited by alanmoo

This should happen automatically when the Titles of pages get localized. Let's confirm that, and check how the donate/newsletter buttons get localized.
@gideonthomas gideonthomas added this to the Sep 23 milestone Sep 9, 2019
@TheoChevalier
Copy link
Contributor

Confirmed for the page titles (see Internet Health and About in French here https://foundation.mozilla.org/fr/ )

Donate and Newsletter will be localized as part of #3529

@youriwims
Copy link
Contributor

Should the other nav items e.g. Initiatives & Participate be localized as well?

@TheoChevalier
Copy link
Contributor

TheoChevalier commented Sep 12, 2019 •
edited

We could localize them right now, but I think it doesn’t make sense until the actual page content is localized (which is the case for Internet Health and About)

@youriwims
Copy link
Contributor

youriwims commented Sep 12, 2019 •
edited

Okay, is there an issue opened already for the page content localization?

@TheoChevalier
Copy link
Contributor

There wasn’t, so I filed #3643 and #3642

@youriwims
Copy link
Contributor

Blocked by #3643 & #3642

p.s. Thanks @TheoChevalier !

@alanmoo alanmoo modified the milestones: Sep 23, Oct 7 Sep 24, 2019
@gideonthomas gideonthomas modified the milestones: Oct 7, Icebox Oct 3, 2019
@cadecairos
Copy link

@TheoChevalier What's the state of this issue?

@TheoChevalier
Copy link
Contributor

We can close this, there’s no engineering work required as this gets localized as we localize all linked pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked engineering localization 🌎
Projects
None yet
Milestone
Icebox
Development

No branches or pull requests
5 participants
@cadecairos @TheoChevalier @alanmoo @gideonthomas @youriwims