New Participate Page #1748

gvn · 2018-08-16T22:58:35Z

Related issue: #1717

gvn · 2018-08-17T16:39:56Z

For design review:

Page:
https://foundation-mofostaging-pr-1748.herokuapp.com/participate2/

Edit in CMS:
https://foundation-mofostaging-pr-1748.herokuapp.com/cms/pages/38/edit/

CC @kristinashu

kristinashu · 2018-08-17T20:18:25Z

Page is looking good! There are no major issues but here are the P1s:

Share CTA

Add FB and Twitter icon to “Spread the word” CTA (this copy will probably updated later)
Copy: The internet needs your help. From signing a petition, contributing to a project, to attending events, you can make the Internet a better place http://foundation.mozilla.org/participate/

Time commitment tags

on Firefox, font in time commitment should be Nunito sans (not serif font in screen cap)

Top hero banner (see comp or Abstract)

dividing line at bottom of hero banner should be Light Gray ($light-gray) #cccccc instead of the #979797 that is there

~~- [ ] increase space below the yellow button and above the dividing line from mb-3 to mb-4~~ (nvm)

increase margin bottom of diving line from mb-3 to mb-4

Medium width view (see comp or Abstract)

Make text go across more of the screen for both the hero text and the intro text below
Make hero image full bleed

P2's

I will open a separate ticket for the P2's on Monday. For a sneak peak, see this doc.

cc @beccaklam

gvn · 2018-08-20T19:01:21Z

@kristinashu P1s are done and staged. If they look good please mark your review approved and I'll assign a code reviewer.

Let's move P2s to a new ticket. Thanks!

kristinashu · 2018-08-20T19:49:14Z

Cool, thanks @gvn! For the share messaging, can I update the pre-populated text somewhere in the CMS?

kristinashu · 2018-08-20T20:19:30Z

@gvn if the share messaging isn't editable in the CMS, then can you please use the copy above for all the platforms?

I've opened a new ticket for P2's #1749 and will delete the list above to avoid any confusion.

gvn · 2018-08-20T20:28:42Z

All of the copy is editable in the CMS. Feel free to change it on staging if you'd like!

kristinashu · 2018-08-20T20:31:54Z

Whaaaat!? Awesome! Will approve design review now.

kristinashu

Design is good! Ready for code review.

mmmavis

Left some comments and questions.

mmmavis · 2018-08-21T18:35:49Z

network-api/networkapi/wagtailpages/models.py

@@ -494,11 +494,170 @@ class InitiativesPage(PrimaryPage):
    ]


+# TODO: Remove this model after ParticipatePage2 is in use


remove this?

We will eventually! Not yet though.

mmmavis · 2018-08-21T18:54:21Z

network-api/networkapi/wagtailpages/models.py

+        ordering = ['sort_order']  # not automatically inherited!
+
+    def __str__(self):
+        return self.page.title + '->' + self.highlight.title


Where does this appear in UI? I can't seem to find any text on site / admin dashboard that has ->.

TBH this is copied from elsewhere and seems to be needed, but I'm not sure why. 🤷‍♀️

mmmavis · 2018-08-21T18:54:50Z

network-api/networkapi/wagtailpages/models.py

@@ -623,6 +886,7 @@ class Homepage(MetadataPageMixin, Page):
        'Styleguide',
        'NewsPage',
        'ParticipatePage',


do we need to remove ParticipatePage?

We will eventually. Right now there will be two ParticipatePage templates so that we don't have to take down the current /participate page while we build the new one on prod.

kk makes sense

mmmavis · 2018-08-21T18:55:58Z

network-api/networkapi/wagtailpages/templates/wagtailpages/tags/card-cta.html

+      <a class="social-link social-link-twitter" href="https://twitter.com/home?status={{ twitter }}"></a>
+      {% endif %}
+
+      {% if email_body %}


do we need to check email_subject here as well?

Yeah, I guess that's a good idea.

fixed

This reverts commit 8b108cc.

gvn added 15 commits August 6, 2018 11:35

hero stuff

20d42ce

more scaffolding

a9a85ed

augmented cards

9ab2463

adding commitment to style guide

62aaa2f

cta scaffold

036d39f

Merge branch 'master' into gh-1717

a9c44db

adding a 2nd participate template

e57e647

Merge branch 'master' into gh-1717

5e4b08d

WET approach

55fdc8e

more template scaffolding

1dd498b

cta

6059675

tweak

a8d0176

Merge branch 'master' into gh-1717

772d681

adding 2nd set of highlights

4ab1e99

adding more ctas

bf6e4fb

cadecairos temporarily deployed to foundation-mofostaging-pr-1748 August 16, 2018 22:58 Inactive

migration yo

6f183c5

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 16, 2018 22:59 Inactive

Merge branch 'master' into gh-1717

74f317c

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 16, 2018 23:01 Inactive

lint

78ff7f7

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 16, 2018 23:27 Inactive

gvn requested a review from kristinashu August 17, 2018 16:40

gvn added 4 commits August 20, 2018 10:15

basic p1 tweaks

0012570

scaffolding social links

ae28618

adding social glyphs

d4c37e9

better share links

f9925a5

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 20, 2018 18:50 Inactive

lint busting

ec561e8

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 20, 2018 18:59 Inactive

kristinashu mentioned this pull request Aug 20, 2018

Participate page: design review P2's #1749

Closed

11 tasks

kristinashu approved these changes Aug 20, 2018

View reviewed changes

gvn requested a review from mmmavis August 20, 2018 20:42

gvn changed the title ~~New Participate Page (WIP!)~~ New Participate Page Aug 21, 2018

mmmavis previously requested changes Aug 21, 2018

View reviewed changes

gvn added 2 commits August 21, 2018 13:42

Merge branch 'master' into mozilla-gh-1717

96d9bdf

squashing all the models

9a353f9

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 21, 2018 20:52 Inactive

lint!

4a09804

gvn temporarily deployed to foundation-mofostaging-pr-1748 August 21, 2018 21:02 Inactive

cadecairos temporarily deployed to foundation-mofostaging-pr-1748 August 21, 2018 21:14 Inactive

tweak for email body and subject

b260914

gvn deployed to foundation-mofostaging-pr-1748 August 21, 2018 21:25 View deployment

gvn requested a review from mmmavis August 21, 2018 21:26

mmmavis approved these changes Aug 21, 2018

View reviewed changes

gvn merged commit 8b108cc into master Aug 21, 2018

gvn added a commit that referenced this pull request Aug 21, 2018

Revert "New Participate Page (#1748)"

6ae6442

This reverts commit 8b108cc.

gvn added a commit that referenced this pull request Aug 21, 2018

Revert "New Participate Page (#1748)"

6a68eea

This reverts commit 8b108cc.

gvn mentioned this pull request Aug 21, 2018

Revert "New Participate Page" #1756

Merged

gvn added a commit that referenced this pull request Aug 21, 2018

Revert "New Participate Page (#1748)" (#1756)

053829a

This reverts commit 8b108cc.

Pomax deleted the gh-1717 branch October 30, 2018 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Participate Page #1748

New Participate Page #1748

gvn commented Aug 16, 2018 •

edited

gvn commented Aug 17, 2018 •

edited

kristinashu commented Aug 17, 2018 •

edited by gvn

gvn commented Aug 20, 2018

kristinashu commented Aug 20, 2018

kristinashu commented Aug 20, 2018

gvn commented Aug 20, 2018

kristinashu commented Aug 20, 2018

kristinashu left a comment

mmmavis left a comment

mmmavis Aug 21, 2018

gvn Aug 21, 2018

mmmavis Aug 21, 2018

gvn Aug 21, 2018

mmmavis Aug 21, 2018

gvn Aug 21, 2018

mmmavis Aug 21, 2018

mmmavis Aug 21, 2018

gvn Aug 21, 2018

		@@ -494,11 +494,170 @@ class InitiativesPage(PrimaryPage):
		]


		# TODO: Remove this model after ParticipatePage2 is in use

New Participate Page #1748

New Participate Page #1748

Conversation

gvn commented Aug 16, 2018 • edited

gvn commented Aug 17, 2018 • edited

kristinashu commented Aug 17, 2018 • edited by gvn

Share CTA

Time commitment tags

Top hero banner (see comp or Abstract)

Medium width view (see comp or Abstract)

P2's

gvn commented Aug 20, 2018

kristinashu commented Aug 20, 2018

kristinashu commented Aug 20, 2018

gvn commented Aug 20, 2018

kristinashu commented Aug 20, 2018

kristinashu left a comment

Choose a reason for hiding this comment

mmmavis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gvn commented Aug 16, 2018 •

edited

gvn commented Aug 17, 2018 •

edited

kristinashu commented Aug 17, 2018 •

edited by gvn