Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ajv-cli as dependency #1863

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Remove ajv-cli as dependency #1863

merged 2 commits into from
Sep 27, 2018

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Sep 26, 2018

Dependabot had a PR to update this, but digging through the code shows we don't actually use ajv-cli anywhere (nor anything ajv), so rather than bump the version, this PR just removes it from the dependency list.

@Pomax Pomax requested a review from gvn September 26, 2018 00:03
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1863 September 26, 2018 00:03 Inactive
@Pomax Pomax changed the title nothing uses ajv-cli Remove ajv-cli as dependency Sep 26, 2018
Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me- it was probably used way back in the static site generator days. Review app seems fine.

@Pomax Pomax merged commit 51df727 into master Sep 27, 2018
@Pomax Pomax deleted the remove-ajv-cli branch September 27, 2018 18:28
@gvn
Copy link
Contributor

gvn commented Sep 27, 2018

Yeah should be fine...it was for validating pulled JSON against now unused JSON schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants