Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI: High priority detail page items #1875

Merged
merged 13 commits into from
Oct 2, 2018
Merged

PNI: High priority detail page items #1875

merged 13 commits into from
Oct 2, 2018

Conversation

gvn
Copy link
Contributor

@gvn gvn commented Sep 28, 2018

Related issue: #1860

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1875 September 28, 2018 21:05 Inactive
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1875 September 28, 2018 21:22 Inactive
@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 September 28, 2018 21:40 Inactive
@gvn
Copy link
Contributor Author

gvn commented Sep 28, 2018

@kristinashu
Copy link

kristinashu commented Sep 28, 2018

Thank you for all these, it's looking good! There are a few things but these could be done as follow ups:

  • You removed the Customer Help field which is good but should also remove the Helptext field for it.

screen shot 2018-09-28 at 3 07 58 pm

  • Please update copy in this one to "If a password is required, you must change the default password" and update "Can't be determined" to "Not required".

screen shot 2018-09-28 at 3 09 57 pm

  • *NEW: add seal for 'meets minimum security standards': Yes, No, Can't determine (will design three badges, each product will display on of them)

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 1, 2018 17:36 Inactive
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design is good! Ready for code review.

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 1, 2018 20:48 Inactive
@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 1, 2018 21:29 Inactive
@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 1, 2018 21:36 Inactive
@gvn gvn requested a review from alanmoo October 1, 2018 21:46
@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 1, 2018 23:45 Inactive
alanmoo
alanmoo previously requested changes Oct 2, 2018
Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty solid, just squash migrations?

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1875 October 2, 2018 17:00 Inactive
@gvn gvn requested a review from alanmoo October 2, 2018 17:17
@gvn gvn dismissed alanmoo’s stale review October 2, 2018 17:18

squashed migrations

@gvn gvn merged commit dd20479 into master Oct 2, 2018
@Pomax Pomax deleted the pni-progress branch October 30, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants