Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Post vote graphs #1957

Merged
merged 11 commits into from Oct 18, 2018
Merged

WIP: Post vote graphs #1957

merged 11 commits into from Oct 18, 2018

Conversation

alanmoo
Copy link
Contributor

@alanmoo alanmoo commented Oct 17, 2018

Even if this doesn't get merged yet, it's a good branch to use to wire up the data from the back end.

See #1888

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1957 October 17, 2018 15:07 Inactive
@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-1957 October 17, 2018 16:41 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 01:06 Inactive
@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 14:51 Inactive
@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 18:19 Inactive
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 18:24 Inactive
@kristinashu
Copy link

Approving so Mavis can add Share functionality and Analytics. But will open a follow-up, low priority, ticket for some styling things.

Could also do the text update separately?

"Majority" and "super creepy" and "not likely to buy it" should reflect the votes.
screen shot 2018-10-18 at 12 10 13 pm

@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 19:29 Inactive
@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 19:37 Inactive
slider refinement.
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 19:40 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-1957 October 18, 2018 19:46 Inactive
@kristinashu
Copy link

Opened #1966 and #1968

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg ship it

@alanmoo alanmoo merged commit 5f8bd3c into master Oct 18, 2018
@kristinashu
Copy link

lol

@Pomax Pomax deleted the creepy-graph branch October 30, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants