This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
fix(scripts): ensure dependent flow_metadata columns are set sanely #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbooth
commented
Feb 22, 2017
| @@ -253,23 +271,6 @@ | |||
| AND flow_metadata.begin_time <= '{day}'::DATE + '1 day'::INTERVAL; | |||
| """ | |||
|
|
|||
| Q_INSERT_EVENTS = """ | |||
There was a problem hiding this comment.
I like to keep these definitions in invocation order to make reading them more logical, since they're a bit distant from the point of usage.
This was referenced Feb 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
This needs to be accompanied with an equivalent update to the existing
flow_metadatato properly fix the issue. That could be done with a bespoke standalone query or we could just drop the data and reimport it using these changes over the weekend. The flow event import has less moving parts than the activity event import, so I expect it be a smoother ride than last weekend if we take that route.@rfk r?