This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
fix(scripts): count from the end when parsing date from file name #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbudhram
reviewed
Apr 13, 2017
import_events.py
Outdated
| @@ -157,7 +157,7 @@ def get_unpopulated_days(): | |||
| print message | |||
| for key in s3.list(prefix=s3_prefix): | |||
| filename = path.basename(key.name) | |||
| day = "-".join(filename[:-4].split("-")[1:]) | |||
| day = "-".join(filename[:-4].split("-")[-3:]) | |||
There was a problem hiding this comment.
we can fix it by counting back three parts from the end
It is not 100% obvious to me why go back 3 when only 1 extra hyphen was added?
There was a problem hiding this comment.
Good point, thanks. I've added a comment to make this clearer.
vbudhram
approved these changes
Apr 13, 2017
philbooth
force-pushed
the
phil/robust-date
branch
from
fa02fda
to
2f91989
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email events file name in S3 has an extra hyphenated part, which caused
import_events.pyto include an extra part in the date string. Instead of assuming that everything after the first hyphenated part is a date, we can fix it by counting back three parts from the end.@vbudhram r?