-
Notifications
You must be signed in to change notification settings - Fork 26
assemble all db repos #56
Conversation
Looks good. But looks like you'll need to |
00e5550
to
7ca9ea1
Compare
Thanks @jrgm, now we're green |
maybe it would be less weird if instead of the npm dep if we just changed the |
except then we'd need to promote the db-server deps up. clearly i need to stop looking at this. 🍺 |
Things I've looked at which seem fine:
Random minor queries:
Apart from delving into all of the code (which just looks like a re-arrangement with probable changes to requires) then this all looks fine to me! :) r+ with nit regarding backend tests. Totally bogus @dannycoates! |
@@ -0,0 +1,39 @@ | |||
language: node_js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this .travis.yml in a random subdirectory actually get run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
If true, we need to figure out a way to run both sets of tests under travis |
IIUC the next step here is for danny to comment on chilts' queries above, then we can rebase for a merge. |
I went ahead and rebased this and merged in train-42 from the other repos. Let's get it merged and we can file follow-up bugs for further cleanup. Merging r=@chilts |
Eh, sorry I haven't looped back to this yet. @rfk, thanks for the merge anyway. I see @philbooth took the followups, lmk if I can help with anything :) |
fixes #54
New layout:
The db-server dep is moved in at the root level and required as a dependency by package.json and the mem bits are now intermixed in bin and lib. This allows everything to be in sync while allowing us to publish fxa-auth-db-server as a module to npm for 3rd party implementations.
Eventually we might want to rename this repo to reflect that its not just mysql, but its no big deal to leave it, and nothing will need to change for fxa-dev or prod. I've already got this running locally with fxa-auth-server with only a few minor changes.
Note, this requires npm >= 2.0 for the "file" type dependency.