This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(api): remove device registration from signup/login endpoints #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1507,18 +1505,18 @@ There are no standard failure modes for this endpoint. | |||
| * `POST /get_random_bytes` | |||
| * `POST /account/create` | |||
| * `POST /account/login?keys=true` | |||
| * `POST /account/device` | |||
There was a problem hiding this comment.
While updating the docs, I noticed the position of the device registration request in these flows didn't match reality. Figured it was okay to fix while I was in here.
|
Yipee! r+, though merge conflicts :( |
philbooth
force-pushed
the
phil/ditch-redundant-device-registration
branch
from
b6659f0
to
21ad7f3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rfk @seanmonstar
In light of your conversation, I've gone ahead and removed device registration from the
/account/signupand/account/loginendpoints entirely.r?