This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(server): enforce 'use strict' everywhere #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbooth
commented
Sep 19, 2017
| @@ -40,7 +42,6 @@ module.exports = (log, config) => { | |||
| KEYS.forEach(name => { | |||
| this[name] = keys[name] && keys[name].toString('hex') | |||
| }) | |||
| this.algorithm = 'sha256' | |||
There was a problem hiding this comment.
This throws in strict mode. algorithm is a defined property with a getter that returns 'sha256', but no setter. This line was clobbering it. Presumably we prefer the getter to the raw property (for precisely this reason), hence I deleted this line.
philbooth
commented
Sep 19, 2017
| @@ -467,7 +469,7 @@ module.exports = config => { | |||
| headers, | |||
| options | |||
| ) | |||
| .then(function (response) { | |||
| .then(response => { | |||
| // Update to the new verified tokens | |||
| this.sessionToken = response.sessionToken | |||
| this.keyFetchToken = response.keyFetchToken | |||
There was a problem hiding this comment.
This callback was unbound so we were actually creating two new global variables called sessionToken and keyFetchToken here. Introducing strict mode changed that behaviour to throw and I've fixed the problem using fat arrow.
philbooth
changed the title
philbooth
force-pushed
the
phil/use-strict
branch
from
f07801d
to
05ff96e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Train 96 contains a few things that I expect to improve the performance of auth server routes. In order to maximise the improvement, and because non-strict code prohibits some V8 optimisations, I decided to add
'use strict'directives everywhere and enforce their presence in.eslintrc.As an added bonus, I found two bona fide issues in the code by enabling strict mode. Neither causes any problems in production (one was in test code, the other was harmless but logically insane), but it's a pertinent reminder of why strict mode is to be preferred. I'll call them out explicitly inline.
And sorry, I've ended up creating one of those PRs that I always moan about. I'll make a point of complaining about my own behaviour in next week's retro.
@mozilla/fxa-devs r?