This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(metrics): include full version information in event data #2356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/fxa-amplitude-send#58.
The user-agent parser was originally written with synthesized device names in mind, so it didn't always return the full version string for browsers and operating systems. Since then, we started using the same code for our event data, meaning that we're getting an incomplete picture of the browser/os that our users are on.
This change tweaks the user-agent code so that it returns full version info, and tweaks the code for synthesizing device names so that it remains consistent(ish) with its old behaviour.
@mozilla/fxa-devs r?