merge strings for train 23086 #420
Conversation
| msgid "" | ||
| "Thank you for reaching out to Mozilla Support about " | ||
| "<b>%(escapedLowercaseTopic)s</b> for <b>%(escapedSelectedPlan)s</b>. We'll " | ||
| "contact you via email as soon as possible." | ||
| "<b>%(escapedLowercaseTopic)s</b> for <b>%(escapedSelectedProduct)s</b>. " |
There was a problem hiding this comment.
I got pinged by the Italian localizers, asking how to deal with this.
I might be wrong, but you're taking original translations starting with uppercase, and reusing them after making them lowercase via JS.
https://github.com/mozilla/fxa/blob/07cefc18148d0b17f5240120a84fe151a5032088/packages/fxa-content-server/app/scripts/models/support-form.js#L15
That is incredibly fragile (I'd go as far as to say it's broken):
- JS might not be able to manage the correct transformation for locales.
- You don't know what capitalization a language should use in the middle of a sentence.
- In the middle of a sentence it might need a different case.
There was a problem hiding this comment.
I didn't wasn't aware of this part, only looking for the en-US section. And if I did, I would have not understood this part. Thanks for pointing it out. And also, I need to check template section too.
There was a problem hiding this comment.
You don't need to check both, check either en-US or templates.
As for the issue, to be honest it's really hard to catch (assuming it's confirmed).
No description provided.