Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Avatar loading transition #1527

Closed
zaach opened this issue Aug 7, 2014 · 3 comments · Fixed by #1666
Closed

Avatar loading transition #1527

zaach opened this issue Aug 7, 2014 · 3 comments · Fixed by #1666
Assignees
@zaach

Comments

@zaach
Copy link
Contributor

zaach commented Aug 7, 2014

Continuing #1327, when processing/uploading images we should show a spinner over the profile image area, as per Ryan's design.
@zaach zaach added this to the train-20 (Aug 25) milestone Aug 7, 2014
@nchapman nchapman mentioned this issue Aug 8, 2014
Merged
@zaach zaach added the avatars label Aug 14, 2014
@zaach zaach changed the title Full page loading screen Avatar loading transition Aug 21, 2014
@zaach
Copy link
Contributor Author

zaach commented Aug 21, 2014

Hey @ryanfeeley. Currently, we show a spinner inside the submit button to indicate that there is a background process happening. Is the idea here to show that spinner over the avatar image rather than the submit button? I.e. we replace the profile image with a spinner, and the submit button remains the same.

@ryanfeeley
Copy link
Contributor

I like the button approach. In the event that the previous page was a link, or just loading a URL from bookmark, might the spinner in place of the avatar make sense?

@zaach
Copy link
Contributor Author

zaach commented Aug 22, 2014

Yeah, that makes sense. There are a couple of cases where we can use that. Thanks!

@ckarlof ckarlof modified the milestones: train-20 (Aug 25), train-21 (Sep 8) Aug 25, 2014
@ckarlof ckarlof modified the milestones: train-21 (Sep 8), train-22 (Sep 22) Sep 4, 2014
@zaach zaach self-assigned this Sep 8, 2014
zaach added a commit that referenced this issue Sep 18, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
113f842 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
zaach added a commit that referenced this issue Sep 18, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
690249b 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
@zaach zaach mentioned this issue Sep 18, 2014
Merged
zaach added a commit that referenced this issue Sep 18, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
f633306 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
zaach added a commit that referenced this issue Sep 18, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
7afa78a 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
@ckarlof ckarlof added the has PR label Sep 22, 2014
zaach added a commit that referenced this issue Sep 22, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
e347e3d 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
zaach added a commit that referenced this issue Sep 22, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
64a63af 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
zaach added a commit that referenced this issue Sep 22, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
9b12345 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
zaach added a commit that referenced this issue Sep 22, 2014
@zaach
fix(avatars): show a spinner icon when loading images with latency
ae1e17f 
This refactors the button progress indicator into something more generic
and uses that to implement progress indicators for profile image loading.

Fixes #1527.
ckarlof added a commit that referenced this issue Sep 23, 2014
@ckarlof
Merge pull request #1666 from mozilla/issue-1527-avatar-load-transition
71db227 
fix(avatars): show a spinner icon when loading images with latency

fixes #1527
r=ckarlof
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zaach zaach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(avatars): show a spinner icon when loading images with latency mozilla/fxa-content-server
3 participants
@zaach @ryanfeeley @ckarlof