This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(avatars): show a spinner icon when loading images with latency #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaach
force-pushed
the
issue-1527-avatar-load-transition
branch
from
690249b
to
f633306
Compare
| img.src = src; | ||
| img.onload = imgOnload; | ||
| img.onerror = imgOnerrer; | ||
| console.log('src', event, src); |
There was a problem hiding this comment.
Do you want to leave the console.log?
|
@shane-tomlinson Hmm, the camera view is still having problems in Chrome that I need to figure out. |
zaach
force-pushed
the
issue-1527-avatar-load-transition
branch
2 times, most recently
from
7afa78a
to
e347e3d
Compare
zaach
force-pushed
the
issue-1527-avatar-load-transition
branch
2 times, most recently
from
64a63af
to
9b12345
Compare
|
Okay, this is ready for review. |
This refactors the button progress indicator into something more generic and uses that to implement progress indicators for profile image loading. Fixes #1527.
zaach
force-pushed
the
issue-1527-avatar-load-transition
branch
from
9b12345
to
ae1e17f
Compare
zaach
changed the title
ckarlof
added a commit
that referenced
this pull request
Sep 23, 2014
fix(avatars): show a spinner icon when loading images with latency fixes #1527 r=ckarlof
|
Hard to test locally, so let's get it into latest to see it go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the button progress indicator into something more generic and uses that to implement progress indicators for profile image loading.
Fixes #1527.
@shane-tomlinson or @nchapman r?