This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
"Mistyped email" does nothing in email-first flow if email query parameter is specified.
#6033
Assignees
Comments
|
It should do something! What would that be? Unless this is a situation that is forcing the user into one account, go to a regular sign in page. |
shane-tomlinson
pushed a commit
that referenced
this issue
Apr 13, 2018
If a relier specified an email for the email-first flow, users that clicked on "Mistyped email" saw no visible change in the screen. In reality, there was a subtle change, the user was redirected to `/`, but the redirected back to `/signin` or `/signup`. This happened because on the 2nd render, the index page saw that the relier model contained an email address and redirected back to where the user just was. To get around this, before checking the email and redirecting, clear the email from the relier model. The email is saved into the formPrefill model since the email elements on the next page have a `name` attribute, and that will be used to prefill the email when the user comes back. Clear as mud, huh? fixes #6033
shane-tomlinson
pushed a commit
that referenced
this issue
Apr 13, 2018
If a relier specified an email for the email-first flow, users that clicked on "Mistyped email" saw no visible change in the screen. In reality, there was a subtle change, the user was redirected to `/`, but the redirected back to `/signin` or `/signup`. This happened because on the 2nd render, the index page saw that the relier model contained an email address and redirected back to where the user just was. To get around this, before checking the email and redirecting, clear the email from the relier model. The email is saved into the formPrefill model and that will be used to prefill the email when the user comes back. A small change to the router was needed to. In the "email-first" flow, ensure the user can go back. fixes #6033
ghost
assigned
shane-tomlinson
pushed a commit
that referenced
this issue
Apr 16, 2018
If a relier specified an email for the email-first flow, users that clicked on "Mistyped email" saw no visible change in the screen. In reality, there was a subtle change, the user was redirected to `/`, but the redirected back to `/signin` or `/signup`. This happened because on the 2nd render, the index page saw that the relier model contained an email address and redirected back to where the user just was. To get around this, before checking the email and redirecting, clear the email from the relier model. The email is saved into the formPrefill model and that will be used to prefill the email when the user comes back. A small change to the router was needed to. In the "email-first" flow, ensure the user can go back. fixes #6033
shane-tomlinson
pushed a commit
that referenced
this issue
Apr 16, 2018
) r=@philbooth If a relier specified an email for the email-first flow, users that clicked on "Mistyped email" saw no visible change in the screen. In reality, there was a subtle change, the user was redirected to `/`, but the redirected back to `/signin` or `/signup`. This happened because on the 2nd render, the index page saw that the relier model contained an email address and redirected back to where the user just was. To get around this, before checking the email and redirecting, clear the email from the relier model. The email is saved into the formPrefill model and that will be used to prefill the email when the user comes back. A small change to the router was needed to. In the "email-first" flow, ensure the user can go back. fixes #6033
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems like we should allow the user to go back to the
/screen. If the relier wants to force the user to use a particular email address, they should useaction=force_authrather thanaction=email. @ryanfeeley - thoughts?The text was updated successfully, but these errors were encountered: