This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(email-first): Ensure "Mistyped email" links work as expected. #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
philbooth
reviewed
Apr 16, 2018
app/tests/spec/views/index.js
Outdated
| assert.isTrue(view.checkEmail.calledWith('testuser@testuser.com')); | ||
| assert.isTrue(view.checkEmail.calledOnceWith('testuser@testuser.com')); | ||
| assert.isFalse(relier.has('email')); | ||
| assert.equal(view.formPrefill.get('email'), 'testuser@testuser.com'); |
There was a problem hiding this comment.
Worth adding an assertion for model.get('relierEmail'), or do we consider that an implementation detail that's covered by functional/other tests?
If a relier specified an email for the email-first flow, users that clicked on "Mistyped email" saw no visible change in the screen. In reality, there was a subtle change, the user was redirected to `/`, but the redirected back to `/signin` or `/signup`. This happened because on the 2nd render, the index page saw that the relier model contained an email address and redirected back to where the user just was. To get around this, before checking the email and redirecting, clear the email from the relier model. The email is saved into the formPrefill model and that will be used to prefill the email when the user comes back. A small change to the router was needed to. In the "email-first" flow, ensure the user can go back. fixes #6033
shane-tomlinson
force-pushed
the
issue-6033-mistyped-email-with-query-param
branch
from
3f54012
to
412b246
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a relier specified an email for the email-first flow, users
that clicked on "Mistyped email" saw no visible change in the
screen.
In reality, there was a subtle change, the user was redirected
to
/, but the redirected back to/signinor/signup.This happened because on the 2nd render, the index page saw
that the relier model contained an email address and redirected
back to where the user just was.
To get around this, before checking the email and redirecting,
clear the email from the relier model. The email is saved
into the formPrefill model since the email elements on
the next page have a
nameattribute, and that willbe used to prefill the email when the user comes back.
fixes #6033
@mozilla/fxa-devs - r?