This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
chore(sass-lint): add sass linting #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDA
force-pushed
the
issue-3372-sass-linting
branch
2 times, most recently
from
a73a51d
to
3c22f8e
Compare
|
|
|
remove unused .scss-lint.yml file add sasslint to grunt lint task
TDA
force-pushed
the
issue-3372-sass-linting
branch
from
3c22f8e
to
c885ef6
Compare
|
@pdehaan Removed the unused file, and added the sasslint to lint tasks. |
|
LGTM. |
| @@ -1,4 +1,6 @@ | |||
| .avatar-spinner { | |||
| @extend %fill-avatar; | |||
There was a problem hiding this comment.
need to check this visually
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sass-lint and grunt-sass-lint to our workflow.
Fixes #3372
@pdehaan