This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(tests): update tests for recovery code updates #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
vbudhram
commented
Apr 16, 2018
app/scripts/lib/validate.js
Outdated
| @@ -46,7 +46,7 @@ define(function (require, exports, module) { | |||
| // TOTP codes are 6 digits | |||
| const TOTP_CODE = /^[0-9]{6}$/; | |||
| // Recovery codes are 10 alpha numeric or 8 hex strings | |||
| const RECOVERY_CODE = /^(([a-z0-9]{10})|([a-f0-9]{8}))$/; | |||
| const RECOVERY_CODE = /^([a-zA-Z0-9]{1,10})$/; | |||
There was a problem hiding this comment.
Updated this regex to be a little more flexible to changes that might come from mozilla/fxa-auth-db-mysql#333.
There was a problem hiding this comment.
How likely are 1 .. 7 recovery code lengths? Could make the cardinality {8,10} if they're not going to happen?
|
@mozilla/fxa-devs r? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tests to be backwards compatible with mozilla/fxa-auth-db-mysql#333.