Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include context param in fxa_status webchannel message #3116

Closed
rfk opened this issue Oct 24, 2019 · 3 comments · Fixed by #4179 or #4188
Closed

Include context param in fxa_status webchannel message #3116

rfk opened this issue Oct 24, 2019 · 3 comments · Fixed by #4179 or #4188
Assignees

Comments

@rfk
Copy link
Contributor

rfk commented Oct 24, 2019

When the browser wants to link out to FxA management pages on the web, it currently includes ?service=sync&context=fx_desktop_v3 query parameters, like so:

https://accounts.firefox.com/settings?service=sync&context=fx_desktop_v3

The presence of these query parameters causes accounts.firefox.com to send an fxa_status webchannel message to the browser to interrogate its login state, and the browser can choose whether to reply with the credentials of the signed-in user.

Now that it's possible to sign in to the browser without enabling sync, it doesn't really make sense to include service=sync in those links, and its presence there risks muddying FxA server-side metrics. We'd like to change these links to just be:

https://accounts.firefox.com/settings?context=fx_desktop_v3

For this to work, we'll need FxA to report the value of context in its fxa_status handshake message to the browser, so that the browser can decide whether or not to respond to the message without having to check for service=sync.

┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-489

@shane-tomlinson shane-tomlinson added this to the Train 150: FxA milestone Oct 25, 2019
@clouserw clouserw removed this from the Train 153: FxA milestone Dec 16, 2019
@vladikoff
Copy link
Contributor

@rfk just to clarify you want the context both in the webchannel message AND in the query param?

@vladikoff
Copy link
Contributor

from mtg: content --> browser, send the given context

@data-sync-user
Copy link
Collaborator

➤ Vladislav Filippov commented:

#4179 ( #4179 ) is the PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants