Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parameter error: metricsContext.utmCampaign #3645

Closed
marniepw opened this issue Dec 11, 2019 · 14 comments
Closed

Invalid parameter error: metricsContext.utmCampaign #3645

marniepw opened this issue Dec 11, 2019 · 14 comments

Comments

@marniepw
Copy link
Contributor

  1. Got an email (10:57am PST, Dec. 11) at my personal gmail address (opened in Safari):
    Title: Find out if you've been part of a breach.
    Body: A lot can happen in a year
  2. Clicked blue "Sign up for breach alerts" button
  3. It opened a new tab (in Safari) to "Sign in to continue to Firefox Monitor"
  4. It prefilled my mozilla.com email address and requested my password.
  5. I entered the password (both by typing and then tried using Safari's autofill).
  6. Error appeared.

Screen Shot 2019-12-11 at 11 13 10 AM

@groovecoder
Copy link
Member

I think this is an issue for the @mozilla/fxa-devs ?

@vladikoff
Copy link
Contributor

Yeap, we should transfer this issue to mozilla/fxa-content-server

@vladikoff
Copy link
Contributor

@marniepw just checking, what's the utm_campaign param in the URL?

@marniepw
Copy link
Contributor Author

@vladikoff - utm_campaign=fx-monitor-twos%20utm_content%3Dfx-monitor-twos-en

@marniepw
Copy link
Contributor Author

And obvs, feel free to move to another repo wherever it best fits..

@pdehaan pdehaan transferred this issue from mozilla/blurts-server Dec 11, 2019
@vladikoff
Copy link
Contributor

Thanks @pdehaan !

@pdehaan
Copy link
Contributor

pdehaan commented Dec 11, 2019

@vladikoff Sorry, you said transfer to mozilla/fxa-content-server, but I only saw the fxa monorepo in the GitHub issue transfer list. Feel free to rehome it if the monorepo isn't the correct place. ❤️

@vladikoff
Copy link
Contributor

fxa is correct, sorry!

@clouserw
Copy link
Member

@vladikoff - utm_campaign=fx-monitor-twos%20utm_content%3Dfx-monitor-twos-en

That is a weird looking string. We'd expect the %20 to be an ampersand, and %3D to be an equals sign. It looks like this is double encoded but also with a space instead of an ampersand?

@marniepw can you give us the URL that the blue button in the email went to?

@groovecoder can you give us the URL that "Sign in to continue to Firefox Monitor" would go to?

Thanks

@digitarald
Copy link

digitarald commented Dec 14, 2019

This happened to my wife as well, using her private email and account.

Her link shows the same broken params: https://accounts.firefox.com/reset_password?…&utm_source=email&utm_campaign=fx-monitor-twos%20utm_content%3Dfx-monitor-twos-en

@vladikoff
Copy link
Contributor

@mozilla/fxa-devs should bump this in priority possibly. Also can amplitude tell us how many places are sending this utm campaign?

@vbudhram
Copy link
Contributor

Looks like this is sending utm_campaign = fx-monitor-twos utm_content=fx-monitor-twos-en which is fails because auth-server and content-server don't accept = and symbols.

Ref:

@clouserw
Copy link
Member

Since these urls bounce through the e.click domain the marketing team was able to fix these URLs, even for emails that were already sent. 👍 Thanks for filing this

@clouserw clouserw added this to the Train 153: FxA milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants