Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): add sass-lint and typescript in eslint #1357

Merged
merged 1 commit into from
Jun 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fxa-payments-server/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# React built files
build
storybook-static

16 changes: 13 additions & 3 deletions packages/fxa-payments-server/.eslintrc
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
parser: "@typescript-eslint/parser"

parserOptions:
ecmaVersion: 2018
sourceType: module
ecmaFeatures:
jsx: true

plugins:
- fxa
- sorting

extends:
- plugin:fxa/client
- plugin:react/recommended

# Required for `import( )` webpack feature
parser: babel-eslint
- "plugin:@typescript-eslint/recommended"

settings:
react:
version: detect

rules:
indent: 0
"@typescript-eslint/indent": ["error", 2]
"@typescript-eslint/no-var-requires": 0
"@typescript-eslint/no-use-before-define": 0
brace-style: 2
handle-callback-err: 0
key-spacing: [2, {"beforeColon": false, "afterColon": true}]
Expand Down
33 changes: 33 additions & 0 deletions packages/fxa-payments-server/.sass-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
files:
lmorchard marked this conversation as resolved.
Show resolved Hide resolved
include: 'src/**/*.scss'
rules:
border-zero: [2, convention: '0']
class-name-format: 0
clean-import-paths: 0
empty-args: [2, include: true]
force-attribute-nesting: 0
force-element-nesting: 0
force-pseudo-nesting: 0
indentation: 0
# waiting on https://github.com/sasstools/sass-lint/issues/70
# to fix incorrectly reported indentation errors
# indentation: [2, size: 2]
leading-zero: 0
mixins-before-declarations: 0
nesting-depth: [2, max-depth: 4]
no-color-literals: 0
no-css-comments: 0
no-empty-args: 0
no-ids: 0
no-important: 0
no-mergeable-selectors: 0
no-misspelled-properties: 0
no-qualifying-elements: 0
no-vendor-prefixes: 0
no-warn: 0
placeholder-in-extend: 0
property-sort-order: [2, ignore-custom-properties: true]
quotes: [2, style: 'single']
shorthand-values: 0
space-after-comma: [2, include: true]
space-around-operator: 0