fix(api): prevent /account/destroy failing due to subhub errors #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I'm going to refine this so that it only ignores |
|
This is better I think. |
philbooth
force-pushed
the
pb/1740-catch-delete-customer-errors
branch
from
d76bb72
to
f627a3c
Compare
philbooth
force-pushed
the
pb/1740-catch-delete-customer-errors
branch
from
f627a3c
to
bfede8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740.
I didn't think #1671 through at all, and foolishly left errors from subhub to abort the
/account/destroyendpoint. Given that it's called optimistically,unknownCustomererrors are expected to come back as a matter of course. This change prevents them causing a problem.Opened against the
train-141branch for a point release.@mozilla/fxa-devs r?