refactor(api): prefer async/await in device/session routes #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
jaredhirsch
approved these changes
Aug 22, 2019
| @@ -32,7 +32,7 @@ describe('lib/redis:', () => { | |||
| }; | |||
| fxaShared = sinon.spy(() => redis); | |||
| wrapper = proxyquire(`${LIB_DIR}/redis`, { | |||
| '../../../fxa-shared/redis': fxaShared, | |||
| '../../fxa-shared/redis': fxaShared, | |||
There was a problem hiding this comment.
oh, I was wondering why this test kept failing locally!
65 tasks
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2286. Contrary to the instructions there though, I've opened this directly against
master.Using one long-lived branch seems more prone to merge conflicts than independently merging short-lived branches as soon as they're ready. And there's nothing that precludes these asyc/await changes from landing bit-by-it.
Note this PR also contains a bonus fix where the path for
proxyquirewas wrong in the redis tests. Not sure where that came from or how long it's been broken, but I needed it to fix the build.@mozilla/fxa-devs r?