fix(sync): send an empty sync object for sign-in flows #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
commented
Oct 9, 2019
| } else if (this.relier.get('service') === 'sync') { | ||
| // if service is already forced to be Sync, then for sign-in | ||
| // attempts we tell Desktop to just enable sync | ||
| loginData.services.sync = {}; |
There was a problem hiding this comment.
This will make sure desktop enables Sync after a sign in
There was a problem hiding this comment.
Tested this locally with Nightly and it doesn't seem to enable sync after reconnecting?
There was a problem hiding this comment.
Yeah requires a desktop patch, cc @mhammond
vladikoff
force-pushed
the
train-147-service-sync
branch
from
30a8514
to
a1f5ac0
Compare
|
See bug 1587691 |
vbudhram
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
@vladikoff I wasn't able to test this against the linked desktop patch, but did look at the code and it LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vbudhram r?
cc @mhammond